Skip to content

Add default_pickle_library_override delegation to InteractiveRunner#37752

Merged
claudevdm merged 2 commits into
apache:masterfrom
praneetnadella:interactive-runner-cloudpickle-fix
Mar 4, 2026
Merged

Add default_pickle_library_override delegation to InteractiveRunner#37752
claudevdm merged 2 commits into
apache:masterfrom
praneetnadella:interactive-runner-cloudpickle-fix

Conversation

@praneetnadella
Copy link
Copy Markdown
Contributor

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the InteractiveRunner by introducing a delegation mechanism for the default_pickle_library_override method. This change ensures that the interactive runner can properly inherit and respect the serialization preferences of its configured underlying runner, providing more consistent and flexible behavior when handling pickling operations within Beam pipelines.

Highlights

  • Pickler Delegation: The InteractiveRunner now includes a default_pickle_library_override method that delegates the choice of the default pickling library to its _underlying_runner.
  • Robustness: The delegation includes a fallback mechanism, ensuring that if the _underlying_runner does not define default_pickle_library_override, the InteractiveRunner's own base class implementation is used.
  • Test Coverage: New unit tests were added to interactive_runner_test.py to verify both the successful delegation of the pickler override and the correct fallback behavior.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • sdks/python/apache_beam/runners/interactive/interactive_runner.py
    • Implemented default_pickle_library_override to delegate to the underlying runner or fallback to the superclass.
  • sdks/python/apache_beam/runners/interactive/interactive_runner_test.py
    • Imported PipelineRunner for type hinting in tests.
    • Added test_default_pickle_library_override_delegates to verify successful delegation.
    • Added test_default_pickle_library_override_fallback to ensure graceful fallback when the underlying runner lacks the method.
Activity
  • No specific human activity (comments, reviews) has been recorded yet for this pull request. The pull request description contains standard contribution guidelines.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@praneetnadella
Copy link
Copy Markdown
Contributor Author

R: @claudevdm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2026

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@claudevdm claudevdm merged commit c9ab4b6 into apache:master Mar 4, 2026
96 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants