Fix Precommit Python Job

[aIbrahiim]

Fixes: #34739

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @aIbrahiim, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a potential race condition in the multi-process shared memory system by ensuring that a server is fully operational before its connection details are published. By introducing a readiness check and a dedicated timeout for server startup, the changes enhance the reliability and stability of the system, particularly in environments where server initialization might experience delays.

Highlights

• Server Readiness Check: Introduced a _wait_for_server_readiness utility to ensure a server is actively listening before its address is made available to clients.
• Threaded Address Publication: Implemented a threaded approach for publishing server addresses, allowing the server to fully initialize before clients attempt to connect, mitigating race conditions.
• Server Initialization Timeout: Added a 60-second timeout for server initialization, preventing indefinite hangs during startup if the server fails to become ready.
• Improved Logging Feedback: Adjusted the logging frequency for server initialization warnings to provide more timely feedback on startup progress.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• sdks/python/apache_beam/utils/multi_process_shared.py
  • Imported the socket module for network operations.
  • Added the _wait_for_server_readiness function, which attempts to connect to a given address repeatedly until successful or a timeout occurs.
  • Modified the _run_server_process function to publish the server's address only after it has passed the readiness check, performed in a separate thread.
  • In the _Shared class's _create_server method, the server is now started in a daemon thread, and its readiness is confirmed using _wait_for_server_readiness before its address is written to a file.
  • Introduced a 60-second timeout in _create_server to detect and raise an error if the shared server process fails to initialize within the specified period.
  • Reduced the interval for logging "Still waiting for server to initialize" warnings from 300 seconds to 5 seconds for more immediate feedback.

Activity

• No human activity (comments, reviews, etc.) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov]

Codecov Report

❌ Patch coverage is 4.65116% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.05%. Comparing base (4e76198) to head (b618979).
⚠️ Report is 10 commits behind head on master.

Files with missing lines	Patch %	Lines
...s/python/apache_beam/utils/multi_process_shared.py	4.65%	41 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #37541      +/-   ##
============================================
- Coverage     40.06%   40.05%   -0.01%     
  Complexity     3404     3404              
============================================
  Files          1177     1177              
  Lines        187083   187190     +107     
  Branches       3581     3581              
============================================
+ Hits          74947    74986      +39     
- Misses       108744   108812      +68     
  Partials       3392     3392              

Flag	Coverage Δ
python	39.68% <4.65%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers