Skip to content

Conversation

@claudevdm
Copy link
Collaborator


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@claudevdm claudevdm marked this pull request as draft October 28, 2025 19:01
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @claudevdm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances Apache Beam's machine learning capabilities by adding a robust integration for writing vector embeddings and their associated contextual data to Google Cloud Spanner. It offers a highly customizable framework for defining how Chunk objects are transformed into Spanner table rows, supporting both default and user-defined schemas, and includes mechanisms for handling metadata flexibly. This addition streamlines the process of building RAG pipelines that leverage Spanner as a vector store.

Highlights

  • Spanner Vector Writer: Introduces a new SpannerVectorWriterConfig for ingesting vector embeddings and metadata into Google Cloud Spanner within Beam RAG pipelines.
  • Flexible Schema Definition: Provides SpannerColumnSpecsBuilder to define custom Spanner table schemas, allowing mapping of Chunk fields (ID, embedding, content, metadata) to columns.
  • Metadata Flattening: Enables flattening specific metadata fields from Chunk.metadata into dedicated Spanner table columns, alongside a JSON column for remaining metadata.
  • Integration Tests: Includes a new integration test suite (spanner_it_test.py) that uses a Spanner emulator to validate various write configurations and schema mappings.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@claudevdm claudevdm changed the title Spannerio vector writer Add spannerio vector writer. Oct 29, 2025
@claudevdm claudevdm marked this pull request as ready for review October 29, 2025 14:56
@claudevdm
Copy link
Collaborator Author

/gemini review

@claudevdm
Copy link
Collaborator Author

R: @damccorm

@claudevdm
Copy link
Collaborator Author

The tests use spanner emulator. I am not sure what will happen in the xlang dataflow test suite, but hopefully the tests will be skipped? Or maybe I need to skip tests if runner is dataflow runner manually.

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a SpannerVectorWriter for RAG pipelines, allowing embeddings and metadata to be written to Google Cloud Spanner. The implementation is well-structured, featuring a flexible SpannerColumnSpecsBuilder for schema definition and comprehensive integration tests using a Spanner emulator. My review includes suggestions to improve code efficiency in duplicate checking, enhance robustness in error handling within the test helpers, and adhere to Python's standard import practices in the test file. Overall, this is a solid contribution that adds valuable functionality.

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - had a few nits, but otherwise this LGTM

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit 6b4dc55 into apache:master Oct 30, 2025
106 of 113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants