Skip to content

[DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch#36046

Closed
Amar3tto wants to merge 1 commit into
apache:release-2.68from
Amar3tto:postcommit_validation_pr
Closed

[DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch#36046
Amar3tto wants to merge 1 commit into
apache:release-2.68from
Amar3tto:postcommit_validation_pr

Conversation

@Amar3tto
Copy link
Copy Markdown
Collaborator

@Amar3tto Amar3tto commented Sep 4, 2025

Tests run on GHA should be queued shortly.

@github-actions github-actions Bot added the build label Sep 4, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Amar3tto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is designed to trigger a comprehensive set of PostCommit and PreCommit tests on the release branch. It achieves this by adding a specific file that signals the CI/CD pipeline to execute these tests. The PR is a temporary, non-mergeable artifact created solely for the purpose of initiating these test runs.

Highlights

  • Test Triggering Mechanism: A new, empty JSON file named "release/trigger_all_tests.json" has been added. This file is intended to act as a trigger for running all PostCommit and PreCommit tests against the release branch.
  • Purpose of Pull Request: This pull request is explicitly marked as "[DO NOT MERGE]" and serves as a temporary mechanism to initiate a full test suite run on the release branch, likely for validation or debugging purposes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 4, 2025

Test Results

15 tests   - 2 182   15 ✅  - 1 961   1h 46m 56s ⏱️ - 1h 7m 52s
12 suites  -   209    0 💤  -   221 
12 files    -   209    0 ❌ ±    0 

Results for commit 74ceab0. ± Comparison against base commit 3461a46.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 4, 2025

Assigning reviewers:

R: @damccorm for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Amar3tto Amar3tto force-pushed the postcommit_validation_pr branch from b84f231 to 74ceab0 Compare September 11, 2025 07:44
@github-actions
Copy link
Copy Markdown
Contributor

Reminder, please take a look at this pr: @damccorm

@Amar3tto
Copy link
Copy Markdown
Collaborator Author

Amar3tto commented Sep 19, 2025

  1. PostCommit Python - pre-existing
  2. PostCommit XVR GoUsingJava Dataflow - pre-existing

@Amar3tto
Copy link
Copy Markdown
Collaborator Author

Amar3tto commented Sep 20, 2025

All necessary checks have been fixed
CC @tvalentyn

@tvalentyn
Copy link
Copy Markdown
Contributor

PostCommit Python - pre-existing
PostCommit XVR GoUsingJava Dataflow - pre-existing

Thanks! is there a GH issue tracking these?

@Amar3tto
Copy link
Copy Markdown
Collaborator Author

PostCommit Python - pre-existing
PostCommit XVR GoUsingJava Dataflow - pre-existing

Thanks! is there a GH issue tracking these?

Yes, #30513, #30519

@Amar3tto Amar3tto closed this Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants