Skip to content

Remove warning for dofns that don't return anything #35521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hjtran wants to merge 1 commit into from
Closed

Remove warning for dofns that don't return anything #35521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions sdks/python/apache_beam/transforms/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1521,9 +1521,6 @@ def _check_fn_use_yield_and_return(fn):
if has_yield and has_return:
Copy link
Contributor Author

@hjtran hjtran Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit conservative with what I removed but I actually wonder if any of the warnings in this function are useful

return True

if not has_yield and not has_return:
_LOGGER.warning(return_none_warning)

return False
except Exception as e:
_LOGGER.debug(str(e))
Expand Down
Loading