AVRO-4225: Fix ClassCastException in FastReaderBuilder for java-class attribute#3715
Open
santosh-d3vpl3x wants to merge 1 commit intoapache:mainfrom
Open
AVRO-4225: Fix ClassCastException in FastReaderBuilder for java-class attribute#3715santosh-d3vpl3x wants to merge 1 commit intoapache:mainfrom
santosh-d3vpl3x wants to merge 1 commit intoapache:mainfrom
Conversation
… attribute When using GenericDatumReader with schemas containing java-class attributes on string fields, FastReaderBuilder.getTransformingStringReader() was casting stringReader.read() directly to String, but GenericData returns Utf8, causing ClassCastException. Fix by explicitly handling both Utf8 and String types, consistent with the rest of the Avro codebase.
|
this will be useful 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fixes AVRO-4225: When using GenericDatumReader with schemas containing
java-classattributes on string fields (e.g.,java.math.BigDecimal), FastReaderBuilder throws:The bug is in
getTransformingStringReader()which casts the result ofstringReader.read()directly toString, butGenericDatareturnsUtf8.The Fix
Explicitly handle both
Utf8andStringtypes, consistent with the rest of the Avro codebase:Verifying this change
Added test class
FastReaderBuilderJavaClassTestwith two test cases:genericDatumReaderWithJavaClassAttribute- tests union type with java-classgenericDatumReaderWithDirectJavaClassString- tests direct string field with java-classBoth tests fail without the fix (ClassCastException) and pass with the fix.
Documentation