AVRO-4229 - Update StatsServer resource handler#3648
Open
terjekid wants to merge 1 commit intoapache:mainfrom
Open
AVRO-4229 - Update StatsServer resource handler#3648terjekid wants to merge 1 commit intoapache:mainfrom
terjekid wants to merge 1 commit intoapache:mainfrom
Conversation
martin-g
approved these changes
Feb 13, 2026
|
|
||
| import org.apache.avro.ipc.stats.StatsPlugin; | ||
| import org.apache.avro.ipc.stats.StatsServlet; | ||
| /* |
Member
There was a problem hiding this comment.
Not caused by this PR but we could improve it.
The ASFv2 licence should be at the top of the file.
Comment on lines
+63
to
+64
| HandlerList handlers = new HandlerList(); | ||
| handlers.setHandlers(new org.eclipse.jetty.server.Handler[] { staticContext, servletContext }); |
Member
There was a problem hiding this comment.
this can be simplified to:
Suggested change
| HandlerList handlers = new HandlerList(); | |
| handlers.setHandlers(new org.eclipse.jetty.server.Handler[] { staticContext, servletContext }); | |
| HandlerList handlers = new HandlerList(staticContext, servletContext); |
| servletContext.addServlet(servletHolder, "/"); | ||
|
|
||
| ResourceHandler resourceHandler = new ResourceHandler(); | ||
| resourceHandler.setBaseResource(Resource.newClassPathResource("/org/apache/avro/ipc/stats/static")); |
Member
There was a problem hiding this comment.
Suggested change
| resourceHandler.setBaseResource(Resource.newClassPathResource("/org/apache/avro/ipc/stats/static")); | |
| Resource baseResource = Resource.newClassPathResource("/org/apache/avro/ipc/stats/static"); | |
| if (baseResource == null) { | |
| throw new IllegalStateException("Static resources not found on classpath"); | |
| } | |
| resourceHandler.setBaseResource(baseResource); |
since the classpath is provided by another Maven module IMO it would be good to make this check here and fail early if for some reason this package is not available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request improves ipc StatsServer, fixing AVRO-4229
Verifying this change
This change is already covered by existing tests, such as TestStatsPluginAndServlet.
Documentation