Skip to content

AVRO-4159 [Java]: complete support for duration #3416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
opwvhk merged 3 commits into from
Jun 27, 2025
Merged

AVRO-4159 [Java]: complete support for duration #3416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03a1fb7
AVRO-4159: Add duration logical type to switch statement
opwvhk Jun 27, 2025
ece9470
AVRO-4159: Improve TimePeriod javadoc
opwvhk Jun 27, 2025
499b538
AVRO-4159: Also test for support by type name
opwvhk Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lang/java/avro/src/main/java/org/apache/avro/LogicalTypes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,9 @@ private static LogicalType fromSchemaImpl(Schema schema, boolean throwErrors) {
case BIG_DECIMAL:
logicalType = BIG_DECIMAL_TYPE;
break;
case DURATION:
logicalType = DURATION_TYPE;
break;
case UUID:
logicalType = UUID_TYPE;
break;
Expand Down
8 changes: 4 additions & 4 deletions lang/java/avro/src/main/java/org/apache/avro/util/TimePeriod.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
* <p>
* Compared to {@link Period java.time.Period}, this class has a smaller range
* ('only' supporting a little less than 358 million years), and cannot support
* negative time periods.
* negative periods.
* </p>
*
* <p>
Expand Down Expand Up @@ -82,9 +82,9 @@
* </tr>
* <tr>
* <td>Time range (approx.)</td>
* <td>0 - 49 days</td>
* <td>0 &endash; 49 days</td>
* <td>unsupported</td>
* <td>-68 - 68 years</td>
* <td>-68 &endash; 68 years</td>
* </tr>
* <tr>
* <td>Date range (approx.)</td>
Expand All @@ -95,7 +95,7 @@
* </table>
*
* @see <a href=
* "https://avro.apache.org/docs/1.11.1/specification/#duration">Avro 1.11
* "https://avro.apache.org/docs/current/specification/#duration">Avro
* specification on duration</a>
*/
public final class TimePeriod implements TemporalAmount, Serializable {
Expand Down
2 changes: 1 addition & 1 deletion lang/java/avro/src/test/java/org/apache/avro/TestLogicalType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ void uuidExtendsString() {
@Test
void durationExtendsFixed12() {
Schema durationSchema = LogicalTypes.duration().addToSchema(Schema.createFixed("f", null, null, 12));
assertEquals(LogicalTypes.duration(), durationSchema.getLogicalType());
assertEquals(LogicalTypes.duration(), LogicalTypes.fromSchema(durationSchema));

assertThrows("Duration requires a fixed(12)", IllegalArgumentException.class,
"Duration can only be used with an underlying fixed type of size 12.",
Expand Down