ATLAS-4071: Use remove() instead of rename loop when deleting property keys#557
Open
uran0sH wants to merge 1 commit intoapache:masterfrom
Open
ATLAS-4071: Use remove() instead of rename loop when deleting property keys#557uran0sH wants to merge 1 commit intoapache:masterfrom
uran0sH wants to merge 1 commit intoapache:masterfrom
Conversation
…y keys Fixes the issue where after deleting a type, new insertions fail when using Elasticsearch as the index backend. Previously, the code attempted to delete property keys by renaming them with a "_deleted_N" suffix in a loop. This approach left the property keys in the graph, causing schema conflicts with ES and preventing subsequent insertions. This change uses the remove() method to properly delete the property key, resolving the conflict. Signed-off-by: Wenyu Huang <huangwenyuu@outlook.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixes the issue where after deleting a type, new insertions fail when using Elasticsearch as the index backend.
Previously, the code attempted to delete property keys by renaming them with a "_deleted_N" suffix in a loop. This approach left the property keys in the graph, causing schema conflicts with ES and preventing subsequent insertions. This change uses the remove() method to properly delete the property key, resolving the conflict.
How was this patch tested?
Create a type and delete it. You can recreate it again successfully.