ATLAS-5191: Atlas UI: Normalize Bootstrap button loading text handling #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawarprasad123
requested review from
chaitalicod,
mandarambawane and
pinal-shah
pawarprasad123
changed the title
chaitalicod
approved these changes
Jan 22, 2026
pawarprasad123
added a commit
that referenced
this pull request
Jan 22, 2026
(cherry-picked from b92063b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We need to standardize how the Bootstrap button “loading text” state is handled across Atlas UIs to avoid unexpected HTML rendering in button labels.
Scope:
dashboardv2 and dashboardv3 use Bootstrap 3.4.1 and load bootstrap.min.js via RequireJS.
Ensure the button setState path sanitizes data--text values before use.
Proposed change:
Add a small patch that overrides Bootstrap’s button setState to treat data--text values as plain text.
Apply the same patch in:
dashboardv3/public/js/main.js
dashboardv3/public/js/migration.js
dashboardv2 already has this patch in public/js/main.js and public/js/migration.js.
Notes:
No UI change expected; only ensures consistent text handling.
Works with existing Bootstrap 3.4.1 dependency.
How was this patch tested?
Manually
