ARTEMIS-6066 deadlock with Core federation consumer#6452
Open
jbertram wants to merge 1 commit into
Open
Conversation
I was unable to reproduce the deadlock with a test so static analysis will have to suffice here. The solution has the benefit of being alongside another bit of code that is explicitly identified as necessary to prevent deadlocks.
| @@ -786,7 +786,6 @@ private void failoverOrReconnect(final Object connectionID, | |||
| sessionsToClose = new HashSet<>(sessions); | |||
| } | |||
| callFailoverListeners(FailoverEventType.FAILOVER_FAILED); | |||
Contributor
There was a problem hiding this comment.
@jbertram why this call wasn't moved with the other?
Contributor
Author
There was a problem hiding this comment.
I didn't move this call because it's not directly related to this deadlock. The thread dump on ARTEMIS-6066 shows that there's no problem with this call since it completes before the call to callSessionFailureListeners.
I suppose it's possible that this call should be moved as well, but I was trying to minimize the changes to only what was necessary to resolve this particular deadlock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was unable to reproduce the deadlock with a test so static analysis will have to suffice here. The solution has the benefit of being alongside another bit of code that is explicitly identified as necessary to prevent deadlocks.