Skip to content

ARTEMIS-5987: Properly handling exceptions with single connection. #6340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ehsavoie wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Open

ARTEMIS-5987: Properly handling exceptions with single connection. #6340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,17 +259,22 @@ protected synchronized void setup() throws Exception {
handler.setup();
handlers.add(handler);
} catch (Exception e) {
logger.trace("Failed to setup session {} for activation {}", i, spec, e);
if (cf != null) {
if (!spec.isSingleConnection()) {
cf.close();
}
cf.close();
}
if (session != null) {
session.close();
}
if (firstException == null) {
firstException = e;
}
if (spec.isSingleConnection()) {
// The shared ClientSessionFactory is in a broken state; stop the loop
// all remaining sessions would fail with "ClientSession closed while
// creating session", masking the real error.
break;
}
}
}
//if we have any exceptions close all the handlers and throw the first exception.
Expand Down