ARTEMIS-5599 Support key password in Netty SSL#6325
Open
hyperxpro wants to merge 1 commit intoapache:mainfrom
Open
ARTEMIS-5599 Support key password in Netty SSL#6325hyperxpro wants to merge 1 commit intoapache:mainfrom
hyperxpro wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
A JKS keystore can have a private key password that differs from the keystore password (e.g. keytool -genkey -storepass keystore123 -keypass keypass123). Currently, Artemis uses keyStorePassword for both opening the keystore and accessing the private key, so such keystores cannot be used.
Modification:
Added a new keyPassword parameter to the Netty SSL acceptor and connector configuration. When set, it is used to access the private key; when not set, keyStorePassword is used as before.
Result:
Fixes: ARTEMIS-5599