ARTEMIS-5861 use timeout when closing Netty ChannelGroups #6197
+25
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbertram
force-pushed
the
ARTEMIS-5861
branch
from
0ed49c2 to
0d3a4d9
Compare
|
|
||
| public static final boolean DEFAULT_WEB_SOCKET_COMPRESSION_SUPPORTED = false; | ||
|
|
||
| public static final String QUIET_PERIOD = "quietPeriod"; |
Contributor
There was a problem hiding this comment.
did you really need this change? if not can you amend the commit without it please?
Contributor
Author
There was a problem hiding this comment.
Strictly speaking the change wasn't necessary. I changed it so that the order of QUIET_PERIOD & DEFAULT_QUIET_PERIOD matched that of SHUTDOWN_TIMEOUT & DEFAULT_SHUTDOWN_TIMEOUT. The change is really for readability and aesthetics, but I'll take it out and push a separate commit for it.
Contributor
|
only asked a nit-pic. other than that if tests are good.. LGTM |
jbertram
force-pushed
the
ARTEMIS-5861
branch
from
0d3a4d9 to
0c319f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.