ARTEMIS-5852 Lock coordination for acceptors #6191

clebertsuconic · 2026-01-23T22:31:19Z

I'm adding a LockCoordinator to the broker, that will use DistributedLock
to help start and stop acceptors.

You can associate the LockCoordinator with acceptors and an acceptor
serving only clients would then be activated in only one of the brokers.

...ain/java/org/apache/activemq/artemis/lockmanager/etcd/EtcdDistributedLockManagerFactory.java

.../src/main/java/org/apache/activemq/artemis/lockmanager/file/FileBasedLockManagerFactory.java

.../org/apache/activemq/artemis/lockmanager/zookeeper/CuratorDistributedLockManagerFactory.java

clebertsuconic · 2026-01-27T01:49:19Z

I just split this into 2 commits. they are still in the same PR as the etcd still depending on the first commit.

clebertsuconic · 2026-01-28T15:09:09Z

I think this is ready to be merged

...mis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImpl.java

docs/user-manual/lock-cordination.adoc

docs/user-manual/_book.adoc

jbertram · 2026-01-28T21:22:53Z

The commit message refers to both "Leader/Follower" and "LockMonitor." I might suggest something like this:

ARTEMIS-5852 Lock coordination for acceptors

I'm adding a LockCoordinator to the broker, that will use DistributedLock
to help start and stop acceptors.

You can associate the LockCoordinator with acceptors and an acceptor
serving only clients would then be activated in only one of the brokers.

jbertram · 2026-01-28T21:27:57Z

Would it make sense to mark this as tech preview for the time being just so we're not 100% locked into the config, API, etc.? I don't have a strong feeling either way, but thought I'd mention it.

FWIW, we did that before with the locking stuff that Franz implemented.

clebertsuconic · 2026-01-28T21:34:16Z

@jbertram I am fine with adding a note.
I can add a note on the XSD and on the doc.

Do you know of anywhere else I should add this?

I'm adding a LockCoordinator to the broker, that will use DistributedLock to help start and stop acceptors. You can associate the LockCoordinator with acceptors and an acceptor serving only clients would then be activated in only one of the brokers.

clebertsuconic · 2026-01-28T21:43:22Z

@jbertram I added the tech preview note. this note actually gives me a piece of mind merging this... giving me an opportunity to eventually change it. thanks for this suggestion.

clebertsuconic force-pushed the lock branch 18 times, most recently from 3e76798 to 940e9c4 Compare January 26, 2026 17:10

tabish121 reviewed Jan 26, 2026

View reviewed changes

clebertsuconic force-pushed the lock branch 7 times, most recently from 3367529 to 8372c9c Compare January 27, 2026 01:48

clebertsuconic force-pushed the lock branch 3 times, most recently from 521369c to cc8ee7d Compare January 27, 2026 02:05

clebertsuconic force-pushed the lock branch 6 times, most recently from b499bd5 to 5199de8 Compare January 28, 2026 15:07

clebertsuconic force-pushed the lock branch 5 times, most recently from b70f78d to 49ccc5b Compare January 28, 2026 20:57