GH-49764: [C++][Python] Avoid building bundled Abseil outside resolve_dependency#49936
Open
raulcd wants to merge 1 commit intoapache:mainfrom
Open
GH-49764: [C++][Python] Avoid building bundled Abseil outside resolve_dependency#49936raulcd wants to merge 1 commit intoapache:mainfrom
raulcd wants to merge 1 commit intoapache:mainfrom
Conversation
…esolve_dependency
|
|
github-actions
Bot
added
Component: C++
awaiting committer review
Member
Author
|
@github-actions crossbow submit verify-rc-source-python-linux-* |
|
Revision: c8be506 Submitted crossbow builds: ursacomputing/crossbow @ actions-71cba4b15c
|
raulcd
added
CI: Extra: C++
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
With the bump versions for gRPC/Protobuf/Abseil and others a bug was introduced where we build Abseil outside of resolve dependency. This caused to interpret Abseil as System dependency for Arrow Flight when it was bundled and failing to find it when trying to build PyArrow.
What changes are included in this PR?
Reorder resolve_dependency abseil to be done before resolving protobuf in order to not require manually building abseil.
Are these changes tested?
Yes via CI, via archery and validated the local build that previously failed now succeeds
Are there any user-facing changes?
No