GH-49092: [C++][FlightRPC][CI] Nightly Packaging: Add dev-yyyy-mm-dd to ODBC MSI name#49151
Open
alinaliBQ wants to merge 3 commits intoapache:mainfrom
Open
GH-49092: [C++][FlightRPC][CI] Nightly Packaging: Add dev-yyyy-mm-dd to ODBC MSI name#49151alinaliBQ wants to merge 3 commits intoapache:mainfrom
dev-yyyy-mm-dd to ODBC MSI name#49151alinaliBQ wants to merge 3 commits intoapache:mainfrom
Conversation
github-actions
bot
added
CI: Extra: C++
alinaliBQ
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
alinaliBQ
force-pushed
the
gh-49092-rename-nighly-odbc
branch
from
283fd67 to
406bba2
Compare
kou
reviewed
Feb 5, 2026
Comment on lines
+478
to
+485
| msi_name=$(ls *.msi) | ||
| echo $msi_name | ||
| SUFFIX=dev-$(date +%Y-%m-%d)- | ||
| echo $SUFFIX | ||
| INDEX=${#msi_name}-9 | ||
| dev_msi_name="${msi_name:0:$INDEX}${SUFFIX}${msi_name:$INDEX}" | ||
| echo $msi_name | ||
| echo $dev_msi_name |
Member
There was a problem hiding this comment.
How about using sed?
Suggested change
| msi_name=$(ls *.msi) | |
| echo $msi_name | |
| SUFFIX=dev-$(date +%Y-%m-%d)- | |
| echo $SUFFIX | |
| INDEX=${#msi_name}-9 | |
| dev_msi_name="${msi_name:0:$INDEX}${SUFFIX}${msi_name:$INDEX}" | |
| echo $msi_name | |
| echo $dev_msi_name | |
| msi_name=$(ls *.msi) | |
| dev_msi_name=$(echo ${msi_name} | sed -e "s/win64\.msi$/dev-$(date +%Y-%m-%d)-win64.msi/") |
github-actions
bot
added
awaiting changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
#49092
What changes are included in this PR?
dev-yyyy-mm-ddto ODBC MSI name. This is a similar approach to R nightly.Before:
Apache Arrow Flight SQL ODBC-1.0.0-win64.msi. After:Apache Arrow Flight SQL ODBC-1.0.0-dev-2026-02-04-win64.msi.Are these changes tested?
Tested in CI. Successfully renamed file: https://github.com/apache/arrow/actions/runs/21686252848/job/62534629714?pr=49151#step:3:26
Are there any user-facing changes?
Yes, the nightly ODBC file names will be changed as described above.