GH-49146: [C++] Add option to disable atfork handlers#49148
Draft
pitrou wants to merge 1 commit intoapache:mainfrom
Draft
GH-49146: [C++] Add option to disable atfork handlers#49148pitrou wants to merge 1 commit intoapache:mainfrom
pitrou wants to merge 1 commit intoapache:mainfrom
Conversation
07d10a1 to
a9c3279
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The atfork handlers we register in Arrow C++ are generally useful if the Arrow APIs are meant to be used from the child process, but they also have the unfortunate effect of executing non-async-signal-safe code in the child process even if Arrow is not be used there. That is not allowed by POSIX if the parent process is multi-threaded.
There are situations where fork() is only called just before exec(), and therefore it is not necessary to run any atfork handler.
What changes are included in this PR?
GetEnvVarIntegerutility function to automate parsing of a numeric environment variableARROW_REGISTER_ATFORKto disable the registration of atfork handlers at runtimeAre these changes tested?
The new environment variable cannot be easily tested automatically, so I've checked it manually.
Are there any user-facing changes?
No, only a new feature.