GH-41863: [Python][Parquet] Support lz4_raw as a compression name alias#49135
Open
nwoolmer wants to merge 2 commits intoapache:mainfrom
Open
GH-41863: [Python][Parquet] Support lz4_raw as a compression name alias#49135nwoolmer wants to merge 2 commits intoapache:mainfrom
nwoolmer wants to merge 2 commits intoapache:mainfrom
Conversation
Member
|
Thank you for contributing @nwoolmer! |
…should cover both ParquetWriter and write_table. other paths use kwargs, so no change expected.
Author
|
@AlenkaF Just checking the docs build failure. Some of the failures look unrelated to my change, but I am unfamiliar with any dependencies you might have between the pages. |
Member
|
Yes, docstest failures are unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41863
Rationale for this change
Other tools in the parquet ecosystem distinguish between
LZ4andLZ4_RAW, matching the specification: https://parquet.apache.org/docs/file-format/data-pages/compression/LZ4(framing) is of course deprecated. PyArrow does not support it, and instead simplifies the user-facing API, usingLZ4as an alias for theLZ4_RAWcodec.However, PyArrow does not accept
LZ4_RAWas a valid alias for theLZ4_RAWcodec:This is a friction issue, and confusing for some users who are aware of the differences.
What changes are included in this PR?
LZ4_RAWto the acceptable codec names list.LZ4->LZ4_RAWmapping to also acceptLZ4_RAW->LZ4_RAW.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes, an additive change to the accepted codec names.