GH-49110: [C++] Add bounds checking to DataType::field() to return nullptr for out-of-bounds access#49111
Open
HyukjinKwon wants to merge 1 commit intoapache:mainfrom
Open
GH-49110: [C++] Add bounds checking to DataType::field() to return nullptr for out-of-bounds access#49111HyukjinKwon wants to merge 1 commit intoapache:mainfrom
HyukjinKwon wants to merge 1 commit intoapache:mainfrom
Conversation
|
|
…urn nullptr for out-of-bounds access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Previously,
DataType::field(int i)directly accessedchildren_[i]without bounds checking, resulting in undefined behavior for out-of-bounds indices. This could crash or return garbage.What changes are included in this PR?
Added bounds checking to
DataType::field()to returnnullptrfor out-of-bounds access, matching the behavior ofGetFieldByName().Are these changes tested?
Yes, added
TestStructType.FieldAccessOutOfBoundsto verify that out-of-bounds indices returnnullptr.Are there any user-facing changes?
Yes.
DataType::field(i)now safely returnsnullptrfor invalid indices instead of undefined behavior.