-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-36411: [C++][Python] Use meson-python for PyArrow build system #45854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,5 +23,9 @@ source_dir=${1}/python | |
|
|
||
| pushd "${source_dir}" | ||
| export SETUPTOOLS_SCM_PRETEND_VERSION=${PYARROW_VERSION:-} | ||
| ${PYTHON:-python} setup.py sdist | ||
| # Meson dist must be run from a VCS, so initiate a dummy repo | ||
| git init . | ||
| git add --all . | ||
| git commit -m "dummy commit for meson dist" | ||
| ${PYTHON:-python} -m build --sdist . | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've tried a couple of things to try and fix sdist: diff --git a/ci/scripts/python_sdist_build.sh b/ci/scripts/python_sdist_build.sh
index 7bea9c3dc1..a8d849183c 100755
--- a/ci/scripts/python_sdist_build.sh
+++ b/ci/scripts/python_sdist_build.sh
@@ -24,8 +24,12 @@ source_dir=${1}/python
pushd "${source_dir}"
export SETUPTOOLS_SCM_PRETEND_VERSION=${PYARROW_VERSION:-}
# Meson dist must be run from a VCS, so initiate a dummy repo
-git init .
-git add --all .
-git commit -m "dummy commit for meson dist"
+#git init .
+#git config --global --add safe.directory "${source_dir}"
+#git config --global user.name "Your Name"
+#git config --global user.email your.email@example.com
+#git add --all .
+#git commit -m "dummy commit for meson dist"
+${PYTHON:-python} -m pip install build
${PYTHON:-python} -m build --sdist .
popdI am unsure whether creating the git repo is necessary (we are already cloning arrow) and If I install
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
It is because building an sdist calls
Try adding |
||
| popd | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I enclosed this in parentheses so that it gets evaluated as the string "12.0" and not the number; otherwise some functionality in Meson was failing to unpack the major/minor version
Somewhat tangentially it looks like the minimum supported version right now is 14.0 - worth updating?