Add mutable bitwise operations to BooleanArray and NullBuffer::union_many#9692
Open
mbutrovich wants to merge 6 commits intoapache:mainfrom
Open
Add mutable bitwise operations to BooleanArray and NullBuffer::union_many#9692mbutrovich wants to merge 6 commits intoapache:mainfrom
BooleanArray and NullBuffer::union_many#9692mbutrovich wants to merge 6 commits intoapache:mainfrom
Conversation
|
Nice! I noticed this as well, should be a nice win. |
This was referenced Apr 10, 2026
Contributor
|
Thnak you @mbutrovich and @neilconway Instead of a new kernel, would you be wiling to implement this intead? I think ti would take a little more work, but would be more general |
Contributor
Author
I'll take a look! |
…anBuffer's bitand_many and associated tests.
BooleanBuffer::bitand_many and NullBuffer::union_manyBooleanArray and NullBuffer::union_many
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
BooleanArraythat potentially reuse the underlying allocation #8809.Rationale for this change
Several DataFusion PRs (#21464, #21468, #21471, #21475, #21477, #21482, #21532) optimize NULL handling in scalar functions by replacing row-by-row null buffer construction with bulk
NullBuffer::union. When 3+ null buffers need combining, they chain binaryunioncalls, each allocating a newBooleanBuffer.NullBuffer::union_manyreduces this to 1 allocation (clone + in-place ANDs). For example, from #21482:Before:
After:
Per @alamb's suggestion, this PR also implements the general-purpose mutable bitwise operations on
BooleanArrayfrom #8809, following thePrimitiveArray::unary/unary_mutpattern. This builds on theBitAndAssign/BitOrAssign/BitXorAssignoperators added toBooleanBufferin #9567.What changes are included in this PR?
NullBuffer::union_many(&[Option<&NullBuffer>]): combines multiple null buffers in a single allocation (clone + in-place&=). Used by DataFusion for bulk null handling.BooleanArraybitwise operations (6 new public methods):Unary (
op: FnMut(u64) -> u64):bitwise_unary(&self, op)— always allocates a new arraybitwise_unary_mut(self, op) -> Result<Self, Self>— in-place if uniquely owned,Err(self)if sharedbitwise_unary_mut_or_clone(self, op)— in-place if uniquely owned, allocates if sharedBinary (
op: FnMut(u64, u64) -> u64):bitwise_bin_op(&self, rhs, op)— always allocates, unions null buffersbitwise_bin_op_mut(self, rhs, op) -> Result<Self, Self>— in-place if uniquely owned,Err(self)if shared, unions null buffersbitwise_bin_op_mut_or_clone(self, rhs, op)— in-place if uniquely owned, allocates if shared, unions null buffersNote: #8809 proposed the binary variants take a raw buffer and
right_offset_in_bits. This PR takes&BooleanArrayinstead, which encapsulates both and matches existing patterns likeBooleanArray::from_binary.Are these changes tested?
Yes. 23 tests for the
BooleanArraybitwise methods and 6 tests forunion_many, covering:Err/ fallback)Are there any user-facing changes?
Six new public methods on
BooleanArrayand one new public method onNullBuffer.