feat(parquet): add StatisticsConverter::from_column_index#9687
Open
kumarUjjawal wants to merge 1 commit intoapache:mainfrom
Open
feat(parquet): add StatisticsConverter::from_column_index#9687kumarUjjawal wants to merge 1 commit intoapache:mainfrom
kumarUjjawal wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
I think @friendlymatthew is also working on this, maybe you can coordinate efforts? |
Contributor
|
There is this one from @friendlymatthew it would be super helpful to combine efforts (e.g. by reviewing the PRs together) and pinging me when you think they are ready |
Author
|
I have reached out to @friendlymatthew for this, I will get back to you once we decide how to proceed forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
StatisticsConverter::try_newresolves columns throughparquet_column(), which only supports top-level non-nested columns. Because of that, callers that already know the Parquet leaf index for a nested field cannot useStatisticsConverterto read statistics for that field.This blocks reading stats for fields inside structs.
What changes are included in this PR?
StatisticsConverter::from_column_index(...)StatisticsConverter::try_new(...)behavior unchangedfield through the new API
Are these changes tested?
Yes
Are there any user-facing changes?
Yes.
This adds a new public constructor:
StatisticsConverter::from_column_index(...)There are no breaking changes.