feat(parquet): parquet page store prototype#9661
Open
kszucs wants to merge 8 commits intoapache:mainfrom
Open
Conversation
…pache#9637) The CDC chunker's value_offset diverged from actual leaf array positions when null list entries had non-empty child offset ranges (valid per the Arrow columnar format spec). This caused slice_for_chunk to produce incorrect non_null_indices, leading to an out-of-bounds panic in write_mini_batch. Track non-null value counts (nni) separately from leaf slot counts in the chunker, and use them in slice_for_chunk to correctly index into non_null_indices regardless of gaps in the leaf array.
…dtrip verification
Member
Author
|
depends on #9644 |
Member
Author
|
Some general comments on this effort, without details of the implementation. First, I think this is a GREAT idea, and something I wish I had had the time to start myself (the
|
Contributor
|
I wonder if this is something interesting to @XiangpengHao who is working on some other ideas related to ObjectStore APIs to existing systems (e.g. files / io_uring) https://github.com/XiangpengHao/t4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Tt is a prototype opened for early discussion but aims to close #9592
Rationale for this change
Storing multiple versions of a dataset is expensive. CDC-based page deduplication
can eliminate most of that redundancy with no special storage backend required.
What changes are included in this PR?
parquet::arrow::page_store—PageStoreWriterandPageStoreReader{blake3}.pageblobinto a shared store directory. Identical pages across files are stored once.
parquet-page-storeCLI (page_store,clifeatures):write,read,reconstructparquet/examples/page_store_dedup/— end-to-end demo on real data (OpenHermes-2.5)On four variants of an 800 MB dataset (filtered, augmented, appended): 3.1 GB → 563 MB (82% reduction, 5.6×).
Are these changes tested?
Yes — round-trips, multi-page, multi-row-group, nested types, cross-file dedup, page integrity, and reader error cases.
Are there any user-facing changes?
Additive only, gated behind the
page_storefeature flag (off by default). The API and manifest format are explicitly unstable in this PR.