fix: Do not assume missing nullcount stat means zero nullcount#9481
Open
scovich wants to merge 2 commits intoapache:mainfrom
Open
fix: Do not assume missing nullcount stat means zero nullcount#9481scovich wants to merge 2 commits intoapache:mainfrom
scovich wants to merge 2 commits intoapache:mainfrom
Conversation
scovich
commented
Feb 25, 2026
| .map(|null_count| { | ||
| if null_count < 0 { | ||
| return Err(general_err!( | ||
| "Statistics null count is negative {}", |
Contributor
Author
There was a problem hiding this comment.
Indentation change only (review with whitespace ignored)
(again below)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
A reader might be annoyed (performance wart) if a parquet footer lacks nullcount stats, but inferring nullcount=0 for missing stats makes the stats untrustworthy and can lead to incorrect behavior.
What changes are included in this PR?
If a parquet footer nullcount stat is missing, surface it as None, reserving
Some(0)for known-no-null cases.Are these changes tested?
Fixed one unit test that broke, added a missing unit test that covers the other change site.
Are there any user-facing changes?
The stats API doesn't change signature, but there is a behavior change. The existing doc that called out the incorrect behavior has been removed to reflect that the incorrect behavior no longer occurs.