Skip to content

GH-625: Map MinorType getNewFieldWriter returns UnionMapWriter #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidavidm merged 2 commits into from
Feb 25, 2025
Merged

GH-625: Map MinorType getNewFieldWriter returns UnionMapWriter #627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dd83f1
GH-625: Map MinorType getNewFieldWriter returns UnionMapWriter
Feb 21, 2025
07afd46
add test
Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion vector/src/main/java/org/apache/arrow/vector/types/Types.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@
import org.apache.arrow.vector.complex.impl.UnionLargeListViewWriter;
import org.apache.arrow.vector.complex.impl.UnionLargeListWriter;
import org.apache.arrow.vector.complex.impl.UnionListWriter;
import org.apache.arrow.vector.complex.impl.UnionMapWriter;
import org.apache.arrow.vector.complex.impl.UnionWriter;
import org.apache.arrow.vector.complex.impl.VarBinaryWriterImpl;
import org.apache.arrow.vector.complex.impl.VarCharWriterImpl;
Expand Down Expand Up @@ -721,7 +722,7 @@ public FieldVector getNewVector(

@Override
public FieldWriter getNewFieldWriter(ValueVector vector) {
return new UnionListWriter((MapVector) vector);
return new UnionMapWriter((MapVector) vector);
}
},
TIMESTAMPSECTZ(null) {
Expand Down
22 changes: 22 additions & 0 deletions vector/src/test/java/org/apache/arrow/vector/TestMapVector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import org.apache.arrow.vector.complex.reader.FieldReader;
import org.apache.arrow.vector.complex.writer.BaseWriter.ListWriter;
import org.apache.arrow.vector.complex.writer.BaseWriter.MapWriter;
import org.apache.arrow.vector.complex.writer.FieldWriter;
import org.apache.arrow.vector.types.Types.MinorType;
import org.apache.arrow.vector.types.pojo.ArrowType;
import org.apache.arrow.vector.types.pojo.Field;
Expand Down Expand Up @@ -1241,4 +1242,25 @@ public void testMakeTransferPairPreserveNullability() {
assertEquals(intField, vec.getField().getChildren().get(0));
assertEquals(intField, res.getField().getChildren().get(0));
}

@Test
public void testMapTypeReturnsSupportedMapWriter() {
try (final MapVector vector = MapVector.empty("map", allocator, false)) {
vector.allocateNew();
FieldWriter mapWriter = MinorType.MAP.getNewFieldWriter(vector);

mapWriter.startMap();
mapWriter.startEntry();
mapWriter.key().bigInt().writeBigInt(1);
mapWriter.value().integer().writeInt(11);
mapWriter.endEntry();
mapWriter.endMap();

Object result = vector.getObject(0);
ArrayList<?> resultSet = (ArrayList<?>) result;
Map<?, ?> resultStruct = (Map<?, ?>) resultSet.get(0);
assertEquals(1L, getResultKey(resultStruct));
assertEquals(11, getResultValue(resultStruct));
}
}
}
Loading