GH-1142: Fix buffer ownership in VectorSchemaRoot addVector/removeVector#1145
Open
John-W-Lewis wants to merge 1 commit into
Open
GH-1142: Fix buffer ownership in VectorSchemaRoot addVector/removeVector#1145John-W-Lewis wants to merge 1 commit into
John-W-Lewis wants to merge 1 commit into
Conversation
…oveVector Use TransferPair to properly transfer buffer ownership when creating a new VectorSchemaRoot, preventing use-after-free when the original root is closed. Co-authored-by: Cursor <cursoragent@cursor.com>
John-W-Lewis
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
|
Thank you for opening a pull request! Please label the PR with one or more of:
Also, add the 'breaking-change' label if appropriate. See CONTRIBUTING.md for details. |
Author
|
Being neither a chicken nor an egg, I understand that I am unable to label this as "bug-fix". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
VectorSchemaRoot#addVectorand#removeVectorpreviously created a newVectorSchemaRootby sharing rawFieldVectorreferences between the original and new root. This violates Arrow's ownership model: closing either root would release buffers still in use by the other, leading to use-after-free errors.This fix uses
TransferPairto properly transfer buffer ownership to the returned root, consistent with howVectorSchemaRoot#slicealready handles this. After the operation, the original root's vectors are left in a transferred (empty) state and can be reused viaallocateNew().Tests added to verify that the returned root's data remains valid after the original root and input vector are closed.
Closes #1142.
Made with Cursor