GH-46087: [FlightSQL] Allow returning column remarks in FlightSQL's CommandGetTables #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
approved these changes
Apr 25, 2025
lidavidm
reviewed
Apr 27, 2025
singh1203
approved these changes
Apr 28, 2025
Contributor
singh1203
left a comment
singh1203
left a comment
There was a problem hiding this comment.
Apart from indentation, all LGTM.
Thank you!
Member
|
Just to confirm: @lidavidm @mateuszrzeszutek it's expected that the integration tests here will fail until the other implementations get their versions of this PR merged, correct? |
Member
|
Yup, we need all of them merged for the test to pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See apache/arrow#46110
What changes are included in this PR?
A new column metadata value
Are these changes tested?
No; there seem to be no tests that'd verify that
ColumnMetadataworks; should I add unit tests specifically for the new methods?Are there any user-facing changes?
Yes, two new methods