fix(rust/core): Handle the ASCII characters from sqlstate instead of their decimal values#4141
Open
felipecrv wants to merge 1 commit intoapache:mainfrom
Open
fix(rust/core): Handle the ASCII characters from sqlstate instead of their decimal values#4141felipecrv wants to merge 1 commit intoapache:mainfrom
felipecrv wants to merge 1 commit intoapache:mainfrom
Conversation
…their decimal values
Contributor
Author
|
I'm tired of seeing |
lidavidm
reviewed
Mar 25, 2026
| } else if c >= 32 && c <= 126 { | ||
| char::from(c as u8) | ||
| } else { | ||
| '\u{FFFD}' |
Member
There was a problem hiding this comment.
Maybe we can still display the value somehow instead of hiding it? (Just stringify the integer value instead?)
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| let safe_ascii = |c: c_char| -> char { | ||
| if c == 0 { | ||
| '0' |
Member
There was a problem hiding this comment.
I think I'd prefer something that isn't ambiguous with an actual sqlstate of '00000'.
| f, | ||
| "{:?}: {} (sqlstate: {:?}, vendor_code: {})", | ||
| self.status, self.message, self.sqlstate, self.vendor_code | ||
| "{:?}: {} (sqlstate: {}{}{}{}{}, vendor_code: {})", |
Member
There was a problem hiding this comment.
Maybe what'd be better is: if sqlstate is all-NUL, omit it; if all-ASCII, stringify it; else fall back to the current representation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.