fix(csharp/src/Client): Fix some resource management in AdbcDataReader#4134
Open
CurtHagenlocher wants to merge 3 commits intoapache:mainfrom
Open
fix(csharp/src/Client): Fix some resource management in AdbcDataReader#4134CurtHagenlocher wants to merge 3 commits intoapache:mainfrom
AdbcDataReader#4134CurtHagenlocher wants to merge 3 commits intoapache:mainfrom
Conversation
CurtHagenlocher
changed the title
AdbcDataReaderAdbcDataReader
Contributor
Author
|
Can you take a quick look at this @davidhcoe ? |
CurtHagenlocher
commented
Mar 24, 2026
There was a problem hiding this comment.
Pull request overview
This PR improves AdbcDataReader cleanup behavior by centralizing stream disposal and tightening record-batch lifetime management, aiming to prevent leaks and stale reads.
Changes:
- Refactors
Close()to delegate cleanup toDispose(bool). - Ensures the underlying
QueryResult.Streamis disposed during reader disposal. - Disposes the prior
RecordBatchbefore fetching the next one inRead()to avoid stale data after mid-stream failures.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a few small issues I noticed while reviewing a change recently.