fix(c): Generate versioned DLLs and import LIBs when building with MSVC

.github/workflows/native-windows.yml

@@ -260,6 +260,49 @@ jobs:
         with:
           fetch-depth: 0
           persist-credentials: false
+      - name: Set Winlibs version
+        id: winlibs-version
+        shell: pwsh
+        run: |
+          $winlibs_asset_name = "winlibs-x86_64-posix-seh-gcc-15.2.0-mingw-w64ucrt-13.0.0-r4.7z"
+          echo "winlibs_asset_name=$winlibs_asset_name" >> $env:GITHUB_OUTPUT
+
+      - name: Cache Winlibs
+        id: cache-winlibs
+        uses: actions/cache@v5
+        with:
+          path: ${{ runner.temp }}/winlibs
+          key: winlibs-${{ steps.winlibs-version.outputs.winlibs_asset_name }}
+
+      - name: Download and setup Winlibs
+        if: steps.cache-winlibs.outputs.cache-hit != 'true'
+        shell: pwsh
+        run: |
+          $base_url = "https://github.com/brechtsanders/winlibs_mingw/releases/download/15.2.0posix-13.0.0-ucrt-r4/"
+          $asset_name = "${{ steps.winlibs-version.outputs.winlibs_asset_name }}"
+          $hash_expected = "148175f2ba3c4ab0bfd93116b75f7ff172e9e0d06ca8680c8a98c375ec45abb5"
+          $url = $base_url + $asset_name
+
+          Write-Host "Downloading $asset_name..."
+          Invoke-WebRequest -Uri $url -OutFile $asset_name -UseBasicParsing
+
+          Write-Host "Verifying hash..."
+          $hash_actual = (Get-FileHash -Path $asset_name -Algorithm SHA256).Hash.ToLower()
+          if ($hash_actual -ne $hash_expected) {
+            throw "SHA256 mismatch! Expected: $hash_expected, Got: $hash_actual"
+          }
+
+          Write-Host "Extracting..."
+          7z x $asset_name -o"${{ runner.temp }}/winlibs" -y
+          Remove-Item $asset_name -Force
+
+      - name: Add Winlibs to PATH
+        shell: pwsh
+        run: |
+          $winlibs_bin = Join-Path "${{ runner.temp }}" "winlibs\mingw64\bin"
+          $env:PATH="$winlibs_bin;${env:PATH}"
+          echo "PATH=$env:PATH" >> $env:GITHUB_ENV
+
       - name: Get Date
         id: get-date
         shell: bash
@@ -273,6 +316,7 @@ jobs:
         with:
           path: ~/conda_pkgs_dir
           key: conda-${{ runner.os }}-${{ steps.get-date.outputs.today }}-${{ env.CACHE_NUMBER }}-${{ hashFiles('ci/**') }}
+
       - uses: conda-incubator/setup-miniconda@835234971496cad1653abb28a638a281cf32541f  # v3.2.0
         with:
           miniforge-version: latest
@@ -319,3 +363,58 @@ jobs:
           BUILD_ALL: "0"
           BUILD_DRIVER_SQLITE: "1"
         run: .\ci\scripts\python_test.ps1 $pwd $pwd\build
+
+  # ------------------------------------------------------------
+  # MSVC/vcpkg build (no Conda)
+  # ------------------------------------------------------------
+  drivers-vcpkg:
+    name: "C/C++ (vcpkg/${{ matrix.os }}/${{ matrix.config }})"
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: ["windows-latest"]
+        arch: ["x64"]
+        config: ["debug", "release"]
+    steps:
+      - uses: actions/checkout@v6
+        with:
+          fetch-depth: 0
+          persist-credentials: false
+      - name: Add msbuild to PATH
+        uses: microsoft/setup-msbuild@6fb02220983dee41ce7ae257b6f4d8f9bf5ed4ce # v2
+      - name: Setup MSYS2 tools
+        run: |
+          # msys64 is pre-installed on windows but not added to path
+          $env:PATH = "C:\msys64\mingw64\bin;C:\msys64\usr\bin\;C:\msys64\ucrt64\bin;$env:PATH"
+          echo "PATH=$env:PATH" >> $env:GITHUB_ENV
+
+          # Needed for gendef tool in GoUtils.cmake
+          pacman --noconfirm -S mingw-w64-x86_64-tools
+      # TODO(https://github.com/apache/arrow-adbc/issues/3825)
+      - name: Clone vcpkg
+        run: |
+          git clone https://github.com/microsoft/vcpkg.git
+          cd vcpkg
+          git checkout ef7dbf94b9198bc58f45951adcf1f041fcbc5ea0
+          .\bootstrap-vcpkg.bat
+      - name: Install vcpkg dependencies
+        working-directory: c
+        env:
+          VCPKG_ROOT: ${{ github.workspace }}/vcpkg
+        run: |
+          ${{ github.workspace }}/vcpkg/vcpkg.exe install libpq sqlite3 --triplet ${{ matrix.arch }}-windows
+      - name: Build and Install (No ASan)
+        env:
+          CMAKE_BUILD_TYPE: ${{ matrix.config }}
+          VCPKG_ROOT: ${{ github.workspace }}/vcpkg
+        run: |
+          cmake .\c\ --preset windows-${{ matrix.config }} -DCMAKE_VERBOSE_MAKEFILE=ON
+
+          cmake --build .\build\${{ matrix.config }} --target install --config ${{ matrix.config }} --parallel
+      - name: Test
+        env:
+          BUILD_ALL: "0"
+          BUILD_DRIVER_MANAGER: "1"
+          BUILD_DRIVER_MANAGER_USER_CONFIG_TEST: "1"
+          BUILD_DRIVER_SQLITE: "1"
+        run: .\ci\scripts\cpp_test.ps1 $pwd\build\${{ matrix.config }} $pwd\local\${{ matrix.config }}

c/CMakePresets.json

@@ -23,6 +23,47 @@
                 "ADBC_USE_UBSAN": "ON"
             }
         },
+        {
+            "name": "multi-config-windows-base",
+            "displayName": "Base config for Windows without ASAN/UBSAN",
+            "hidden": true,
+            "toolchainFile": "$env{VCPKG_ROOT}/scripts/buildsystems/vcpkg.cmake",
+            "cacheVariables": {
+                "CMAKE_EXPORT_COMPILE_COMMANDS": "ON",
+                "ADBC_BUILD_TESTS": "ON",
+                "ADBC_DRIVER_FLIGHTSQL": "ON",
+                "ADBC_DRIVER_MANAGER": "ON",
+                "ADBC_DRIVER_POSTGRESQL": "ON",
+                "ADBC_DRIVER_SNOWFLAKE": "ON",
+                "ADBC_DRIVER_SQLITE": "ON",
+                "ADBC_BUILD_SHARED": "ON",
+                "ADBC_BUILD_STATIC": "OFF",
+                "ADBC_USE_ASAN": "OFF",
+                "ADBC_USE_UBSAN": "OFF",
+                "ADBC_BUILD_VCPKG": "ON",
+                "CMAKE_TOOLCHAIN_FILE": "$env{VCPKG_ROOT}/scripts/buildsystems/vcpkg.cmake",
+                "CMAKE_C_COMPILER": "cl.exe",
+                "CMAKE_CXX_COMPILER": "cl.exe"
+            }
+        },
+        {
+            "name": "windows-debug",
+            "displayName": "Windows Debug",
+            "inherits": "multi-config-windows-base",
+            "binaryDir": "${sourceDir}/../build/debug",
+            "cacheVariables": {
+                "CMAKE_INSTALL_PREFIX": "${sourceDir}/../local/debug"
+            }
+        },
+        {
+            "name": "windows-release",
+            "displayName": "Windows Release",
+            "inherits": "multi-config-windows-base",
+            "binaryDir": "${sourceDir}/../build/release",
+            "cacheVariables": {
+                "CMAKE_INSTALL_PREFIX": "${sourceDir}/../local/release"
+            }
+        },
         {
             "name": "debug-python",
             "displayName": "debug, all drivers, with tests, without ASan/UBSan (usable from Python)",
@@ -41,6 +82,18 @@
             }
         }
     ],
+    "buildPresets": [
+        {
+          "name": "debug-windows",
+          "configurePreset": "windows-debug",
+          "configuration": "Debug"
+        },
+        {
+          "name": "release-windows",
+          "configurePreset": "windows-release",
+          "configuration": "Release"
+        }
+    ],
     "testPresets": [
         {
             "name": "debug",

c/cmake_modules/AdbcDefines.cmake

@@ -148,6 +148,26 @@ endmacro()
 # Common testing setup
 add_custom_target(all-tests)
 if(ADBC_BUILD_TESTS)
+  if(MSVC)
+    # MSVC emitted warnings for testing code
+    # Unary minus operator applied to unsigned type, result still unsigned
+    add_compile_options(/wd4146)
+    # An integer type is converted to a smaller integer type.
+    add_compile_options(/wd4244)
+    # Class has virtual functions, but its non-trivial destructor is not virtual; instances of this class may not be destructed correctly
+    add_compile_options(/wd4265)
+    # No override available for virtual member function from base
+    add_compile_options(/wd4266)
+    # Signed integral constant overflow
+    add_compile_options(/wd4307)
+    # Move constructor was implicitly defined as deleted
+    add_compile_options(/wd5026)
+    # Class has virtual functions, but its trivial destructor is not virtual
+    add_compile_options(/wd5204)
+    # Implicit fall-through occurs here
+    add_compile_options(/wd5262)
+  endif()
+
   find_package(GTest)
   if(NOT GTest_FOUND)
     message(STATUS "Building googletest from source")

c/cmake_modules/BuildUtils.cmake

@@ -241,6 +241,17 @@ function(ADD_ARROW_LIB LIB_NAME)
                                      VERSION "${ADBC_FULL_SO_VERSION}"
                                      SOVERSION "${ADBC_SO_VERSION}")
 
+    if(WIN32)
+      # Binaries generated on Windows need file version information, otherwise when the binary is part of a Windows installer
+      # the installer won't know to update a previously installed version.
+      set(VERSION_RC_TEMPLATE "${CMAKE_SOURCE_DIR}/version.rc.in")
+      configure_file("${VERSION_RC_TEMPLATE}"
+                     "${CMAKE_CURRENT_BINARY_DIR}/${LIB_NAME}_version.rc" @ONLY)
+
+      target_sources(${LIB_NAME}_shared
+                     PRIVATE "${CMAKE_CURRENT_BINARY_DIR}/${LIB_NAME}_version.rc")
+    endif()
+
     # https://github.com/apache/arrow-adbc/issues/81
     target_compile_features(${LIB_NAME}_shared PRIVATE cxx_std_11)
 
@@ -289,6 +300,19 @@ function(ADD_ARROW_LIB LIB_NAME)
             ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
             INCLUDES
             DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
+
+    # If we're building on Windows using vcpkg, ensure the runtime dependencies of binaries are copied to the install folder.
+    # TODO(https://github.com/apache/arrow-adbc/issues/3826): auto-detect this
+    if(ADBC_BUILD_VCPKG)
+      install(TARGETS ${LIB_NAME}_shared
+                      RUNTIME_DEPENDENCIES
+                      PRE_EXCLUDE_REGEXES
+                      "api-ms-win-.*"
+                      "ext-ms-.*"
+                      POST_EXCLUDE_REGEXES
+                      ".*system32.*"
+              RUNTIME DESTINATION ${RUNTIME_INSTALL_DIR})
+    endif()
   endif()
 
   if(BUILD_STATIC)

c/cmake_modules/DefineOptions.cmake

@@ -232,6 +232,10 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")
   define_option(ADBC_DRIVER_BIGQUERY "Build the BigQuery driver" OFF)
 
   define_option(ADBC_INTEGRATION_DUCKDB "Build the test suite for DuckDB" OFF)
+
+  define_option(ADBC_BUILD_VCPKG
+                "Build on Windows using vcpkg for dependencies and Visual Studio generator."
+                OFF)
 endif()
 
 macro(validate_config)