[AMORO-4044] Fix partition mapping bug in TableEntriesScan for tables with evolved PartitionSpec#4085
Open
j1wonpark wants to merge 1 commit intoapache:masterfrom
Open
Conversation
… with evolved PartitionSpec The entries metadata table returns a unified super-struct partition containing fields from all PartitionSpecs. buildDataFile() and buildDeleteFile() passed this directly to withPartition(), causing partition mismatch after spec evolution. Fix by projecting the unified partition to the spec-specific type using StructProjection. Signed-off-by: Jiwon Park <jpark92@outlook.kr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The entries metadata table returns a unified super-struct partition containing fields from all PartitionSpecs. In
TableEntriesScan, bothbuildDataFile()andbuildDeleteFile()passed this unified partition directly towithPartition(), which causes a partition struct mismatch for files written under a non-latest PartitionSpec. This is the root cause of #4044.This PR fixes the issue at the
TableEntriesScanlevel by projecting the unified partition to the spec-specific partition type usingStructProjection.createAllowMissing(), so that all callers ofTableEntriesScanget correct partition values regardless of spec evolution.Close #4044.
Brief change log
projectPartition()method that usesStructProjection.createAllowMissing()to project the unified partition struct to the file's spec-specific partition typebuildDataFile()andbuildDeleteFile()Partitioning.partitionType(table)for reuseHow was this patch tested?
Documentation
no
not applicable