AMBARI-26556: Add a way to encrypted configurations.json file in the ambari-agent's cache#4087
Open
prabhjyotsingh wants to merge 1 commit intoapache:trunkfrom
Open
AMBARI-26556: Add a way to encrypted configurations.json file in the ambari-agent's cache#4087prabhjyotsingh wants to merge 1 commit intoapache:trunkfrom
prabhjyotsingh wants to merge 1 commit intoapache:trunkfrom
Conversation
Contributor
|
@prabhjyotsingh plz add some unit test for your change |
prabhjyotsingh
commented
Nov 15, 2025
prabhjyotsingh
commented
Nov 15, 2025
Contributor
Author
|
@JiaLiangC sure I've added a few. |
Contributor
Author
|
@JiaLiangC can you help me review this PR? |
Contributor
Author
|
@JiaLiangC can you help me review this PR? After spending more time on this, I realized there’s an internal implementation of ambari_pbkdf2, so I decided to use that instead. |
d4ce5fc to
19f722a
Compare
Contributor
|
@prabhjyotsingh also can you squash your 10 commits into single one? |
…ambari-agent's cache - add unit test - fix unit test and add some comments - add comment for the new value - fix cryptography installation script - use ambari_pyaes instead of downloading a new one - revert install-helper.sh - fix typo - AMBARI-26556: remove salt from config and make it random
19f722a to
03db094
Compare
Contributor
Author
|
@sandeep318kumar sure I just did. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a way to encrypted configurations.json file in the ambari-agent's cache
How was this patch tested?
before enabling encryption:
after enabling encryption: