Skip to content

Chart: fix default args/command for databaseCleanup#63821

Draft
Aakcht wants to merge 1 commit intoapache:mainfrom
Aakcht:fix_databasecleanup_default_command
Draft

Chart: fix default args/command for databaseCleanup#63821
Aakcht wants to merge 1 commit intoapache:mainfrom
Aakcht:fix_databasecleanup_default_command

Conversation

@Aakcht
Copy link
Contributor

@Aakcht Aakcht commented Mar 17, 2026

This PR aligns default databaseCleanup command/args with other containers like cleanup https://github.com/apache/airflow/blob/main/chart/values.yaml#L3314 (and all other airflow containers). Having bash overriding default image entrypoint results in inconsistent behavior and causes issues when running airflow under custom user.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Mar 17, 2026
@Aakcht Aakcht force-pushed the fix_databasecleanup_default_command branch from 594f10d to 5cf3e21 Compare March 17, 2026 14:48
@Aakcht Aakcht force-pushed the fix_databasecleanup_default_command branch from 5cf3e21 to 1dd044e Compare March 17, 2026 14:49
@Aakcht Aakcht requested a review from dstandish as a code owner March 17, 2026 14:49
@jscheffl jscheffl added this to the Airflow Helm Chart 1.21.0 milestone Mar 17, 2026
@jscheffl
Copy link
Contributor

Merge after 1.20.0 release please

@potiuk potiuk marked this pull request as draft March 18, 2026 13:12
@potiuk
Copy link
Member

potiuk commented Mar 18, 2026

@Aakcht This PR has been converted to draft because it does not yet meet our Pull Request quality criteria.

Issues found:

  • Other failing CI checks: Failing: Mergeable. Run prek run --from-ref main locally to reproduce. See static checks docs.

What to do next:

  • The comment informs you what you need to do.
  • Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
  • There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates.
  • Maintainers will then proceed with a normal review.

Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the Airflow Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants