[v3-1-test] Fix callback files losing priority during queue resort (#61232) #61243
+51
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…61232) When the DAG processor resorts its file queue by modification time (e.g., after a bundle refresh), files with pending callbacks could lose their position at the front of the queue. This could delay callback execution (like DAG failure callbacks) if those files happened to have older modification times. The fix partitions the queue during resort: callback files stay at the front in their original order, while only regular files are sorted by mtime. (cherry picked from commit f5e70fc) Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
1 task
ephraimbuddy
requested review from
ephraimbuddy and
jedcunningham
as code owners
85 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the DAG processor resorts its file queue by modification time
(e.g., after a bundle refresh), files with pending callbacks could
lose their position at the front of the queue. This could delay
callback execution (like DAG failure callbacks) if those files
happened to have older modification times.
The fix partitions the queue during resort: callback files stay at
the front in their original order, while only regular files are
sorted by mtime.
(cherry picked from commit f5e70fc)
Co-authored-by: Jed Cunningham 66968678+jedcunningham@users.noreply.github.com