feat(#1797): add message delivery tracking to QueueMessageReference

[jeanouii]

Add isDelivered()/setDelivered() to QueueMessageReference interface with implementations in IndirectMessageReference (boolean field) and NullMessageReference (no-op). PrefetchSubscription.acknowledge() now marks messages as delivered=true when processing DeliveredAck, enabling downstream consumers to distinguish delivered-but-unacked messages.

[jbonofre]

It seems this loop overrides what has been done in the previous loop (line 275). Maybe we should merge the logic in one loop ?

[cshannon]

What caused you to make this change, did you see bugs show up or specific issues with tests? There are no test updates here to demonstrate the issue and fix. I'm not saying the change is incorrect (i haven't reviewed it) but i am wondering what triggered the change here.

[jbonofre]

@cshannon I think it's coming for a flaky test (or needed by a test). @jeanouii am I right ?

[cshannon]

@cshannon I think it's coming for a flaky test (or needed by a test). @jeanouii am I right ?

Yeah that would make sense, if there is an existing test already that is flaky that this fixes then that demonstrates the issue and fix but it would be helpful to know which one

[jeanouii]

@cshannon @jbonofre Not a specific test, but I asked myself many times the question when debugging flaky tests. And I realized even in the Web Console we don't have information on hand.
I don't recall about a very specific test to be honest.
If you guys think we don't need it, I'm ok with it, I'll put it back locally when I need to debug again in the future

[cshannon]

If you guys think we don't need it, I'm ok with it, I'll put it back locally when I need to debug again in the future

I just need time to look at it more, this week has been pretty busy so I'll try to get to the various backlogs of PR reviews next week.