Skip to content

[NO-JIRA] Update enforcer-plugin to releasing with JDK 21 #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattrpav wants to merge 1 commit into from
Closed

[NO-JIRA] Update enforcer-plugin to releasing with JDK 21 #1532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 34 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1133,7 +1133,7 @@
<configuration>
<rules>
<requireMavenVersion>
<version>3.0.5</version>
<version>3.6.3</version>
Copy link
Copy Markdown
Member

@gemmellr gemmellr Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parent pom 37 now requires Maven 3.9 to build. Given 3.8.x is now entirely out of support and new plugin releases are aimed at 3.9+, I'd say its time to do the same (and have already done so in other projects). I'd also defer to its enforcer definition (by removing this one entirely) at this point to simplify the pom.

You could also get rid of the java version check below this one (but not the other one in the release profile) and defer to the parents one. They have also defined a new property in v37 to link all the java verison enforcement and compiler settings together, though personally I prefer having the compiler properties set in the components own pom and so am still setting them regardless.

</requireMavenVersion>
</rules>
</configuration>
Expand Down Expand Up @@ -1337,6 +1337,39 @@
</activation>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<executions>
<execution>
<id>enforce-maven</id>
<goals>
<goal>enforce</goal>
</goals>
<configuration>
<rules>
<requireMavenVersion>
<version>3.6.3</version>
</requireMavenVersion>
</rules>
</configuration>
</execution>
Comment on lines +1344 to +1356
Copy link
Copy Markdown
Member

@gemmellr gemmellr Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could similarly remove this maven version enforcement.

<execution>
<id>enforce-java-version</id>
<goals>
<goal>enforce</goal>
</goals>
<configuration>
<rules>
<requireJavaVersion>
<version>[21,)</version>
<message>You must use Java 21+ during release to support multi-release jars</message>
</requireJavaVersion>
</rules>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
Expand Down