Fixes to MiniAccumulo based on comments in #5999 #6062
Merged
+16
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctubbsii
requested changes
Jan 15, 2026
| String javaHome = System.getProperty("java.home"); | ||
| String javaBin = javaHome + File.separator + "bin" + File.separator + "java"; | ||
|
|
||
| Stream<String> defaultJvmOpts = Stream.of("-XX:+PerfDisableSharedMem", "-XX:+AlwaysPreTouch"); |
Member
There was a problem hiding this comment.
This is fine since the stream isn't reused, but it might be better to put these in a Set.of outside the method, and call .stream() inside the method, to reuse the set.
However, I don't even know why these are here as default options. There's no documentation explaining why they were added. They were added in https://issues.apache.org/jira/browse/ACCUMULO-3699, but no specific explanation about what they were expected to achieve. They may be OBE.
minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloClusterImpl.java
Outdated
Show resolved
Hide resolved
minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloConfigImpl.java
Show resolved
Hide resolved
ctubbsii
approved these changes
Jan 15, 2026
Member
ctubbsii
left a comment
ctubbsii
left a comment
There was a problem hiding this comment.
Looks good. I'm still not sure we actually need those default JVM args (or the default system props, either), but we don't need to determine that in this PR.
dlmarion
added a commit
to dlmarion/accumulo-classloaders
that referenced
this pull request
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.