Fix sorting on bulk import tables in monitor #6059
Merged
+9
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This screenshot is before these changes and shows the sorting bug. Descending sort is selected on both tables for the age column but neither is working (top table is coincidentally correct). (can also see the table width issue on the top table) This screenshot shows both tables sorting properly on age |
ddanielr
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6058
Main changes here:
When a value was not present for the age, the renderers returned "-" which DataTables could not compare to other values so the order was essentially undefined. Now, we map to a value of 0 for sorting those rows.
I took a quick look through other pages and I don't think this bug exists elsewhere.
Unrelated to the bug but still fixed:
autoWidth=falsewhich allows the Bulk Import table to properly resize its width while still respecting the defined percentages. Without this, the table would not dynamically resize if the page width changed. Now it aligns with how the other tables in the monitor behave.