log exception on failure set table prop #6057
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Looked at the other code in ManagerClientServiceHandler that handles setting system,namespace, and table props and those all seem to log exceptions. |
ddanielr
reviewed
Jan 14, 2026
| Map.of(property, value)); | ||
| } | ||
| } catch (IllegalStateException ex) { | ||
| log.warn("Invalid table property, tried to set: tableId: " + tableId.canonical() + " to: " |
Contributor
There was a problem hiding this comment.
Line 574 can also return an IllegalStateException
PropUtil.removeProperties(manager.getContext(),
TablePropKey.of(manager.getContext(), tableId), List.of(property));
This log message should include the table OP instead of assuming it's always a set opt.
keith-turner
commented
Jan 14, 2026
| PropUtil.setProperties(manager.getContext(), TablePropKey.of(manager.getContext(), tableId), | ||
| Map.of(property, value)); | ||
| } else { | ||
| throw new UnsupportedOperationException("table operation:" + op.name()); |
Contributor
Author
There was a problem hiding this comment.
Currently the client code is only calling the RPC w/ the two values. However this server side code should not ignore seeing something else. This new throw should cause an error to be logged and TApplicationException on the client side should this ever happen.
ddanielr
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.