Skip to content

Fix nondeterministic behavior in testPrettyPrint by making iterator assertions order-independent #5962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
annhchen89 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix nondeterministic behavior in testPrettyPrint by making iterator assertions order-independent #5962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 28 additions & 4 deletions core/src/test/java/org/apache/accumulo/core/data/ConditionalMutationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import java.util.HashMap;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Set;

import org.apache.accumulo.core.client.IteratorSetting;
Expand Down Expand Up @@ -193,8 +194,19 @@ public void testPrettyPrint() {
assertTrue(pp.contains("update: name:last value doe"));
assertTrue(pp.contains("update: name:first value john"));
iters = c1.getIterators();
assertTrue(pp.contains("condition: " + FAMILY + ":" + QUALIFIER + " value: " + VALUE
+ " iterator: '" + iters[0] + "' '" + iters[1] + "'"));
assertTrue(pp.contains("condition: " + FAMILY + ":" + QUALIFIER + " value: " + VALUE));
String iterSection = pp.substring(pp.indexOf("iterator:"));
Copy link
Contributor

@dlmarion dlmarion Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious if this is a false positive as the iters object is an array, which is ordered.

for (IteratorSetting iter : iters) {
Map<String,String> props = iter.getOptions();

assertTrue(iterSection.contains("name:" + iter.getName()));
assertTrue(iterSection.contains("class:" + iter.getIteratorClass()));
assertTrue(iterSection.contains("priority:" + iter.getPriority()));

for (Map.Entry<String,String> e : props.entrySet()) {
assertTrue(iterSection.contains(e.getKey() + "=" + e.getValue()));
}
}

// all conditions together
c1 = new Condition(FAMILY2, QUALIFIER2).setValue(VALUE).setVisibility(CVIS2)
Expand All @@ -208,8 +220,20 @@ public void testPrettyPrint() {
assertTrue(pp.contains("update: name:first value john"));
iters = c1.getIterators();
assertTrue(pp.contains("condition: " + FAMILY2 + ":" + QUALIFIER2 + " value: " + VALUE
+ " visibility: '" + c1.getVisibility() + "' timestamp: '" + TIMESTAMP + "' iterator: '"
+ iters[0] + "'"));
+ " visibility: '" + c1.getVisibility() + "' timestamp: '" + TIMESTAMP));

iterSection = pp.substring(pp.indexOf("iterator:"));
for (IteratorSetting iter : iters) {
Map<String,String> props = iter.getOptions();

assertTrue(iterSection.contains("name:" + iter.getName()));
assertTrue(iterSection.contains("class:" + iter.getIteratorClass()));
assertTrue(iterSection.contains("priority:" + iter.getPriority()));

for (Map.Entry<String,String> e : props.entrySet()) {
assertTrue(iterSection.contains(e.getKey() + "=" + e.getValue()));
}
}
}

@Test
Expand Down