use URI instead of URL #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctubbsii
reviewed
Jan 16, 2026
Member
ctubbsii
left a comment
ctubbsii
left a comment
There was a problem hiding this comment.
I do not think we should do this. URI is just an identifier, and could contain almost anything. We are specifically working with URLs because URLs carry semantics about being a resource that is network-reachable at the specified location. URI doesn't do that. All of our URIs are URLs, so we should use the more specific type. That's what allows us to connect to them, create streams to download them, etc. URI would let too many things through that aren't valid, and we wouldn't be able to easily detect that. It would increase the number of edge cases we'd have to take into account, by a lot.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.