tests external modification of cache dir #38
Merged
+124
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlmarion
approved these changes
Jan 14, 2026
ctubbsii
reviewed
Jan 14, 2026
Member
ctubbsii
left a comment
ctubbsii
left a comment
There was a problem hiding this comment.
Test works and looks good, but see my comment for a possible improvement.
...test/java/org/apache/accumulo/classloader/lcc/LocalCachingContextClassLoaderFactoryTest.java
Outdated
Show resolved
Hide resolved
Use the ContextDefinition to identify a file to replace in the test case, rather than selecting files in the directory. Also verify test works after removing the corrupted file. Also clean up after tests.
ctubbsii
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests code added in #37