Remove duplicate method calls in AccessEvaluator methods #99
Conversation
| public static CharSequence unescape(CharSequence auth) { | ||
| int escapeCharCount = 0; | ||
| for (int i = 0; i < auth.length(); i++) { | ||
| final int authLength = auth.length(); |
There was a problem hiding this comment.
Could also make this change to avoid duplicate length() calls in AuthorizationValidator
There was a problem hiding this comment.
I'm not seeing duplicate calls in that class, can you point me to it?
There was a problem hiding this comment.
It only calls it once in the code, noticed the function call is repeatedly called at runtime for each loop iteration. That was what I was thinking of in terms of duplication, but not sure if its worthwhile to avoid that or not.
There was a problem hiding this comment.
I'm seeing that where it is being called from an authorization is being passed in, presumably the auth token is unique. I'm not seeing a loop, can you point me to it?
There was a problem hiding this comment.
The following code is what I was thinking could benefit from the same changes being made elsewhere in this PR.
2 participants
No description provided.