Rename Unity interface traits to *Interface and align IUnityGraphicsD3D12 with C header#25
Merged
Merged
Conversation
…ity's C interface naming conventions; update imports, implementations, and README accordingly.
…erface naming; update imports, implementations, and README accordingly.
…imports, implementations, and sample usage accordingly.
…`UnityGraphicsD3D12Interface`; implement in `impl_d3d12!` macro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IUnityGraphics*trait naming into the*Interfaceform, while also providingIUnity*aliasesUnityGraphicsD3D12Interfacewith the original C header (obsoleteIUnityGraphicsD3D12): removed inheritance fromUnityGraphicsD3D12v2Interfaceand defined its own methods directly (device/command_queue/frame_fence/next_frame_fence_value/resource_state/set_resource_state)Test plan
cargo build --target x86_64-pc-windows-msvc(plugin / sample)cargo buildon macOS / Linux targets