Prepare 0.9: graphics interface trait redesign and module cleanup#24
Merged
Conversation
…st imports in `unity-native-plugin-sample` to simplify structure and avoid redundant module.
… imports across multiple modules for cleanup and organization.
…face` to `UnityGraphicsMetalV1Ext` and `UnityGraphicsMetalV2Ext`, respectively, and introduce `UnityGraphicsVulkanExt`/`UnityGraphicsVulkanV2Ext` to consolidate extension traits.
… and adjust implementations for modularity and clarity. Update sample project imports to reflect changes.
…dant definitions from `d3d11` and `d3d12`.
…mentation; update imports for consistency.
…d updating `get_instance_proc_addr` return type.
…e `profiler` feature; update README and dependencies accordingly.
…onsolidation, module path changes, renamed identifiers, and updated method traits.
… for consistency across modules; update imports and implementations accordingly.
…cument trait changes and add Metal interfaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final round of changes preparing the
0.9release, plus the 0.8 → 0.9 migration guide. (Earlier 0.9-targeted refactors —unity-native-plugin-vulkancrate consolidation, sys-crate split, etc. — landed in previous PRs.)Graphics interface traits
implblocks onUnityGraphicsD3D11,UnityGraphicsD3D12*andUnityGraphicsVulkan*with traits mirroring the underlyingIUnityGraphics*C interfaces;UnityGraphicsMetal*already used this pattern and is retained.v2–v8) traits with macro-based implementations.*Interfaceacross all back-ends (Metal's original convention). An interim rename to*Extwas reverted within the same branch.Module cleanup
ComPtrinto a newwindowsmodule (was duplicated betweend3d11/d3d12).metal/objc2.rsintometal.rs.define_unity_interfacemacro intolib.rs.Features
profiler_callbacksintoprofiler.Fixes
VulkanInstance::get_instance_proc_addrnow returns the standardashOption<PFN_vkVoidFunction>instead of a sys-defined enum (unwrap_pfnremoved).AccessTexture→AccessBuffer.Docs
README.mdcovering all of the above plus changes from earlier 0.9 PRs (vulkan crate consolidation,ComPtrmove, D3D11 typo fixes,GfxRenderer::ReservedCFE→Nvn2).Test plan
cargo buildfor each supported feature combination (d3d11,d3d12,vulkan,metal,profiler)cargo buildon Windows, macOS, and a non-matching platform to confirm feature gatingunity-native-plugin-samplestill builds against the new trait API