7287-convert-flag_values-to-same-type-as-variable#181
Closed
mphemming wants to merge 16 commits intoaodn:masterfrom
Closed
7287-convert-flag_values-to-same-type-as-variable#181mphemming wants to merge 16 commits intoaodn:masterfrom
mphemming wants to merge 16 commits intoaodn:masterfrom
Conversation
…the hourly products.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Origin/python 311
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to convert
flag_valuesto the same type as the variable. This will convert numeric values in a list (e.g. [1,2,3]) to bytes (e.g. 1b, 2b, 3b), and resolves this warning.Tested LTSP creation with this update and a file was successfully created. Noting that the LTSPs also have the same warning as above because a string is used for the flag_values.
This PR should be merged into the V2 branch.