Skip to content

feature: add new endpoint to get latest wave buoy date#228

Open
leslieduan wants to merge 3 commits intomainfrom
feature/8031-as-a-developer-i-want-to-have-a-new-endpoint-in-ogc-api-to-return-latest-available-date-of-wave-buoys-so-that-imos-live-project-can-have-it
Open

feature: add new endpoint to get latest wave buoy date#228
leslieduan wants to merge 3 commits intomainfrom
feature/8031-as-a-developer-i-want-to-have-a-new-endpoint-in-ogc-api-to-return-latest-available-date-of-wave-buoys-so-that-imos-live-project-can-have-it

Conversation

@leslieduan
Copy link

No description provided.

Copy link
Collaborator

@utas-raymondng utas-raymondng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, please also add test case to cover your change

public enum FeatureId {
summary("summary"),
first_data_available("first_data_available"),
latest_date("latest_date"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the data cover expand later? if not then better to have a very specific name for wave buoy, same for latest_date and timeseries

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, will update it.

}

public byte[] getWaveBuoysLatestDate(){
HttpHeaders headers = new HttpHeaders();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated code, why not refactor it all to a @PostConstruct init function?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants