Bugfix/unmatched path returns 404#77
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses incorrect error handling for unmatched routes (returning 500 instead of 404) and introduces request-path normalization so trailing slashes don’t break handler resolution under Spring Boot 3 (e.g., when a proxy appends /).
Changes:
- Add a
NoResourceFoundExceptionhandler inGlobalExceptionHandlerto return 404 for unmapped paths/resources. - Introduce
TrailingSlashNormalizationFilterto strip trailing slashes for application endpoints while excluding framework-managed paths (springdoc + actuator). - Add/extend tests to assert 404 behavior for unmatched paths and validate trailing-slash normalization behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/main/java/au/org/aodn/oceancurrent/exception/GlobalExceptionHandler.java | Adds a dedicated 404 handler for NoResourceFoundException to avoid the catch-all mapping these cases to 500. |
| src/main/java/au/org/aodn/oceancurrent/configuration/TrailingSlashNormalizationFilter.java | Adds a highest-precedence filter to normalize trailing slashes while skipping swagger/api-docs/webjars/actuator routes. |
| src/test/java/au/org/aodn/oceancurrent/controller/ImageMetadataControllerTest.java | Adds a regression test ensuring unmatched paths return 404. |
| src/test/java/au/org/aodn/oceancurrent/configuration/TrailingSlashNormalizationFilterTest.java | Adds unit tests for trailing-slash normalization and excluded paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.