Fix PHP 8.4 implicit nullable deprecation warnings#36
Open
SimonBarrettACT wants to merge 4 commits intoanystack-sh:mainfrom
Open
Fix PHP 8.4 implicit nullable deprecation warnings#36SimonBarrettACT wants to merge 4 commits intoanystack-sh:mainfrom
SimonBarrettACT wants to merge 4 commits intoanystack-sh:mainfrom
Conversation
…ings Upgrade laravel-zero/framework from ^9.2 to ^10.0 and bump related dependencies (pest ^2.0, termwind ^1.15, symfony/yaml ^6.2|^7.0) to resolve implicit nullable parameter deprecation warnings on PHP 8.4. Fixes anystack-sh#35 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
Using this branch before it's mergedSince the pre-built Clone and aliasgit clone -b fix/php84-deprecation-warnings https://github.com/SimonBarrettACT/porter.git ~/porter-fix
cd ~/porter-fix && composer install
alias porter="php ~/porter-fix/porter"Add the alias to your echo 'alias porter="php ~/porter-fix/porter"' >> ~/.zshrcVerifyporter statusYou should see clean output with no |
- Migrate phpunit.xml.dist to PHPUnit 10 schema (remove deprecated attributes: convertErrorsToExceptions, convertNoticesToExceptions, convertWarningsToExceptions, backupStaticAttributes; replace coverage with source element) - Replace inspire command test with list command test since the inspire command is not registered in this application Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add vendor patch for laravel-zero/foundation InteractsWithContainer (mock, partialMock, spy methods) to fix implicit nullable deprecation warnings on PHP 8.4 - Add composer post-install/post-update scripts to apply patch automatically - Rename InspireCommandTest to ListCommandTest and replace broken inspire test with list command test Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Full dependency upgrade to eliminate all PHP 8.4 implicit nullable deprecation warnings without needing vendor patches: - laravel-zero/framework: ^10.0 -> ^12.0 (illuminate v12.53.0) - pestphp/pest: ^2.0 -> ^3.0 (with PHPUnit 11) - nunomaduro/termwind: ^1.15 -> ^2.0 - mockery/mockery: ^1.4.4 -> ^1.6 - symfony/yaml: ^6.2|^7.0 -> ^7.0 - php: ^8.1 -> ^8.2 (required by laravel-zero v12) Removes the vendor patch for laravel-zero/foundation as v12 includes the nullable type fixes natively. Fixes anystack-sh#35 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
laravel-zero/frameworkfrom^9.2to^12.0(Illuminate v12.53.0) to resolve all PHP 8.4 implicit nullable deprecation warningspestphp/pestfrom^1.21.3to^3.0(PHPUnit 11)nunomaduro/termwindfrom^1.14to^2.0mockery/mockeryfrom^1.4.4to^1.6symfony/yamlfrom^6.2to^7.0^8.1to^8.2(required by laravel-zero v12)phpunit.xml.distfrom PHPUnit 9 to PHPUnit 11 schemainspirecommand test withlistcommand testphp-cs-fixerwithnullable_type_declaration_for_default_null_valuerule againstapp/— no application code changes neededFixes #35
Test plan
php portershows no deprecation warnings on PHP 8.4php porter statusworks correctlyvendor/bin/pestpasses with no deprecation warnings🤖 Generated with Claude Code